Skip to content

Commit

Permalink
Auto merge of #132625 - compiler-errors:cache-only-if-opaque, r=lcnr
Browse files Browse the repository at this point in the history
Only disable cache if predicate has opaques within it

This is an alternative to rust-lang/rust#132075.

This refines the check implemented in rust-lang/rust#126024 to only disable the global cache if the predicate being considered has opaques in it. This is still theoretically unsound, since goals can indirectly rely on opaques in the defining scope, but we're much less likely to hit it.

It doesn't totally fix rust-lang/rust#132064: for example, `lemmy` goes from 1:29 (on rust 1.81) to 9:53 (on nightly) to 4:07 (after this PR). But I think it's at least *more* sound than a total revert :/

r? lcnr
  • Loading branch information
bors committed Nov 6, 2024
2 parents 128a2c7 + 041af8e commit 45ca9bb
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 45ca9bb

Please sign in to comment.