-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: support mistral as model provider #1455
Conversation
@danielglh is attempting to deploy a commit to the LobeHub Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for raising your pull request and contributing to our Community |
cb1cfd9
to
4fa4c06
Compare
@danielglh please rebase the main and solve the conflicts~ |
4fa4c06
to
de1a8c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1455 +/- ##
==========================================
+ Coverage 92.38% 92.57% +0.19%
==========================================
Files 230 232 +2
Lines 12278 12447 +169
Branches 1483 1509 +26
==========================================
+ Hits 11343 11523 +180
+ Misses 935 924 -11 ☔ View full report in Codecov by Sentry. |
@danielglh I think the code is really clean and great. This time can we bump up the test coverage to 100% for the mistral provider and anthropic provider relative code? |
@arvinxx already did |
For sure. I've already added tests for mistral (mostly just copied from the perplexity/moonshot tests). Not sure how to check the test coverage of each provider though. @arvinxx |
@arvinxx added tests for anthropic and mistral. Hopefully the coverage should be good now. |
plz rebase it |
cd46b63
to
388e2c0
Compare
@arvinxx done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM, I'll merge it~ Thanks for your contribution👏
❤️ Great PR @danielglh ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
## [Version 0.133.0](v0.132.2...v0.133.0) <sup>Released on **2024-03-07**</sup> #### ✨ Features - **misc**: Support Mistral model provider. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Support Mistral model provider, closes [#1455](#1455) ([4f94bfe](4f94bfe)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
🎉 This PR is included in version 0.133.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [Version 1.15.0](v1.14.5...v1.15.0) <sup>Released on **2024-03-07**</sup> #### ✨ Features - **misc**: Support Mistral model provider. #### 🐛 Bug Fixes - **misc**: Fix anthropic streaming on Vercel/Cloudflare. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Support Mistral model provider, closes [lobehub#1455](https://github.com/bentwnghk/lobe-chat/issues/1455) ([4f94bfe](4f94bfe)) #### What's fixed * **misc**: Fix anthropic streaming on Vercel/Cloudflare, closes [lobehub#1480](https://github.com/bentwnghk/lobe-chat/issues/1480) ([227101a](227101a)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
## [Version 0.133.0](lobehub/lobe-chat@v0.132.2...v0.133.0) <sup>Released on **2024-03-07**</sup> #### ✨ Features - **misc**: Support Mistral model provider. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Support Mistral model provider, closes [#1455](lobehub/lobe-chat#1455) ([4f94bfe](lobehub/lobe-chat@4f94bfe)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
Added a new model provider, Mistral, along with the 5 models it currently provides.
📝 补充信息 | Additional Information
Different API Parameters
According to the official API doc, Mistral API doesn't seem to support these parameters:
presence_penalty, frequency_penalty
. Therefore the implementation needs to pick only the supported parameters and thepresence_penalty, frequency_penalty
settings do not affect Mistral models.