GEOMESA-3409: Arrow: axis order request parameter #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geomesa currently defaults to always reading and writing Arrow encoding as NORTH_EAST, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. Axis Order parameter supported values: - NORTH_EAST translates to: North = Latitude = Y Axis, East = Longitude = X Axis - EAST_NORTH translates to: East = Longitude = X Axis, North = Latitude = Y Axis The request parameter is optional and if not specified axis order defaults to the existing behavior which is NORTH_EAST.
epyatkevich
changed the title
epyatkevich
changed the title
elahrvivaz
reviewed
Oct 30, 2024
...esa-arrow-gt/src/main/scala/org/locationtech/geomesa/arrow/vector/ArrowAttributeWriter.scala
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Oct 30, 2024
...mesa-arrow-gt/src/main/scala/org/locationtech/geomesa/arrow/vector/SimpleFeatureVector.scala
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Oct 30, 2024
...mesa-arrow-gt/src/main/scala/org/locationtech/geomesa/arrow/vector/SimpleFeatureVector.scala
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Oct 30, 2024
...mesa-arrow-gt/src/main/scala/org/locationtech/geomesa/arrow/vector/SimpleFeatureVector.scala
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Oct 30, 2024
...arrow/geomesa-arrow-jts/src/main/java/org/locationtech/geomesa/arrow/jts/GeometryVector.java
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Oct 30, 2024
...esa-arrow-jts/src/main/java/org/locationtech/geomesa/arrow/jts/impl/AbstractPointVector.java
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Oct 30, 2024
geomesa-index-api/src/main/scala/org/locationtech/geomesa/index/iterators/ArrowScan.scala
Outdated
Show resolved
Hide resolved
|
looks like a good start, thanks for working on it! I think i'd prefer to replace most references to AxisOrder with |
Geomesa currently defaults to always reading and writing Arrow geometries in Lat/Lon order, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. Axis Order parameter supported values: - LatLon translates to: Latitude = Y Axis = North, Longitude = X Axis = East - LonLat translates to: Longitude = X Axis = East, Latitude = Y Axis = North The request parameter is optional and if not specified axis order defaults to the existing behavior which is LatLon.
Geomesa currently defaults to always reading and writing Arrow geometries in Lat/Lon order, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. Axis Order parameter supported values: - LatLon translates to: Latitude = Y Axis = North, Longitude = X Axis = East - LonLat translates to: Longitude = X Axis = East, Latitude = Y Axis = North The request parameter is optional and if not specified axis order defaults to the existing behavior which is LatLon.
epyatkevich
commented
Nov 1, 2024
...mesa-arrow-gt/src/main/scala/org/locationtech/geomesa/arrow/vector/SimpleFeatureVector.scala
Show resolved
Hide resolved
|
Added similar logic to all the remaining geometries |
Geomesa currently defaults to always reading and writing Arrow geometries in Lat/Lon order, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. Axis Order parameter supported values: - LatLon translates to: Latitude = Y Axis = North, Longitude = X Axis = East - LonLat translates to: Longitude = X Axis = East, Latitude = Y Axis = North The request parameter is optional and if not specified axis order defaults to the existing behavior which is LatLon.
Geomesa currently defaults to always reading and writing Arrow geometries in Lat/Lon order, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. Axis Order parameter supported values: - LatLon translates to: Latitude = Y Axis = North, Longitude = X Axis = East - LonLat translates to: Longitude = X Axis = East, Latitude = Y Axis = North The request parameter is optional and if not specified axis order defaults to the existing behavior which is LatLon.
elahrvivaz
reviewed
Nov 6, 2024
elahrvivaz
reviewed
Nov 6, 2024
...mesa-arrow-gt/src/main/scala/org/locationtech/geomesa/arrow/vector/SimpleFeatureVector.scala
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Nov 6, 2024
...arrow/geomesa-arrow-jts/src/main/java/org/locationtech/geomesa/arrow/jts/GeometryVector.java
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Nov 6, 2024
...arrow/geomesa-arrow-jts/src/main/java/org/locationtech/geomesa/arrow/jts/GeometryVector.java
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Nov 6, 2024
...ow/geomesa-arrow-jts/src/main/java/org/locationtech/geomesa/arrow/jts/WKBGeometryVector.java
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Nov 6, 2024
...-arrow-jts/src/main/java/org/locationtech/geomesa/arrow/jts/impl/AbstractGeometryVector.java
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Nov 6, 2024
...rrow-jts/src/main/java/org/locationtech/geomesa/arrow/jts/impl/AbstractLineStringVector.java
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Nov 6, 2024
...rrow-jts/src/main/java/org/locationtech/geomesa/arrow/jts/impl/AbstractLineStringVector.java
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Nov 6, 2024
...ector/src/main/scala/org/locationtech/geomesa/process/transform/ArrowConversionProcess.scala
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Nov 6, 2024
...ector/src/main/scala/org/locationtech/geomesa/process/transform/ArrowConversionProcess.scala
Outdated
Show resolved
Hide resolved
|
looks good, thanks for bearing with me! I think we can merge after the next round of minor revisions. |
Geomesa currently defaults to always reading and writing Arrow geometries in Lat/Lon order, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. Axis Order parameter supported values: - LatLon translates to: Latitude = Y Axis = North, Longitude = X Axis = East - LonLat translates to: Longitude = X Axis = East, Latitude = Y Axis = North The request parameter is optional and if not specified axis order defaults to the existing behavior which is LatLon.
Geomesa currently defaults to always reading and writing Arrow geometries in Lat/Lon order, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. The request parameter is optional and if not specified axis order defaults to the existing behavior which is Lat/Lon.
Geomesa currently defaults to always reading and writing Arrow geometries in Lat/Lon order, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. The request parameter is optional and if not specified axis order defaults to the existing behavior which is Lat/Lon.
Geomesa currently defaults to always reading and writing Arrow geometries in Lat/Lon order, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. The request parameter is optional and if not specified axis order defaults to the existing behavior which is Lat/Lon.
elahrvivaz
reviewed
Nov 12, 2024
...esa-arrow-jts/src/main/java/org/locationtech/geomesa/arrow/jts/impl/AbstractPointVector.java
Outdated
Show resolved
Hide resolved
Geomesa currently defaults to always reading and writing Arrow geometries in Lat/Lon order, with the new axis order parameter allow the user to request the encoding to be explicitly specified per request. The request parameter is optional and if not specified axis order defaults to the existing behavior which is Lat/Lon.
elahrvivaz
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOMESA-3409: Geomesa currently defaults to always reading and writing Arrow encoding as Lat / Lon axis order.
With the new axis order request parameter allow the user to request the encoding to be explicitly specified per request.
Axis Order parameter supported values:
LatLontranslates to: Latitude = Y Axis = North, Longitude = X Axis = EastLonLattranslates to: Longitude = X Axis = East, Latitude = Y Axis = NorthThe request parameter is optional and if not specified axis order defaults to the existing behavior which is
LatLon.Notes: