fix: Avert breakage with rust 1.80.0 #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting time 0.3.36 as minimally required version in accordance to rust-lang/rust#125319 (comment)
|
@locka99 This should reduce the time necessary to review the fix to a minimum for you. |
as this might help detecting upcoming rust issues earlier next time.
This was referenced Jul 17, 2024
|
This has already been taken care of in a52f8f7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vlnzrv I think this is the least invasive resolution to the ongoing crate breakage due to the regression in 1.80.0.
Starting in eight days the opcua crate won't build in an up to date rust/stable anymore.