update benchmark_models cli #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* save file with --file only, to md, csv, or jsonl based on file extension
kxtran
approved these changes
Jul 30, 2024
log10/cli/completions.py
Outdated
Comment on lines
407
to
414
| if path.suffix.lower() == ".csv": | ||
| # save the dataframe to a csv file | ||
| all_df.to_csv(path, index=False) | ||
| rich.print(f"Dataframe saved to csv file: {path}") | ||
| elif path.suffix.lower() == ".jsonl": | ||
| all_df.to_json(path, orient="records", lines=True) | ||
| rich.print(f"Dataframe saved to jsonl file: {path}") | ||
| elif path.suffix.lower() == ".md": |
There was a problem hiding this comment.
we could extract the path.suffix.lower() to be in a variable
There was a problem hiding this comment.
done. reuse the name ext_name at ln 312.
log10/cli/completions.py
Outdated
Comment on lines
407
to
414
| if path.suffix.lower() == ".csv": | ||
| # save the dataframe to a csv file | ||
| all_df.to_csv(path, index=False) | ||
| rich.print(f"Dataframe saved to csv file: {path}") | ||
| elif path.suffix.lower() == ".jsonl": | ||
| all_df.to_json(path, orient="records", lines=True) | ||
| rich.print(f"Dataframe saved to jsonl file: {path}") | ||
| elif path.suffix.lower() == ".md": |
There was a problem hiding this comment.
can we also add the else case to raise Error?
There was a problem hiding this comment.
we have checked the extension name at the beginning of the func (ln 310-316), so no need to check again here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save file with --file only, to md, csv, or jsonl based on file extension