Improve OpenRelik File Download Handling and Folder Management #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchop
requested changes
Jan 30, 2025
|
|
||
| self.logger.info(f"Created folder {self.folder_id}") | ||
| self.logger.info(f"Updating folder {self.folder_id}") | ||
| _ = self.openrelik_folder_client.update_folder( |
There was a problem hiding this comment.
You can skip the empty assignment here
Comment on lines
+130
to
+136
| if not self.folder_id or not self.openrelik_folder_client.folder_exists( | ||
| self.folder_id | ||
| ): | ||
| folder_id = self.openrelik_folder_client.create_root_folder( | ||
| self.folder_id = self.openrelik_folder_client.create_root_folder( | ||
| f"{self.incident_id}" | ||
| ) | ||
| self.logger.info(f"Created folder {folder_id}") | ||
|
|
||
| self.logger.info(f"Created folder {self.folder_id}") |
There was a problem hiding this comment.
If we're using the same folder for all files, wouldn't we want this piece of logic to go in SetUp? It looks like there would be a race condition if multiple threads ran at the sam time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enhances the OpenRelik processor by improving error handling during file downloads and streamlining folder management within OpenRelik. It also updates several dependencies.
Technical Details:
DownloadWorkflowOutputfunction indftimewolf/lib/processors/openrelik.pynow uses the dedicatedopenrelik_api_client.download_filefunction and explicitly handles cases where the download fails. It logs an error message and returnsNoneif the download is unsuccessful, preventing downstream errors and providing better feedback to the user.DownloadWorkflowOutputhas been updated tostr | Noneto reflect the possible return ofNonein case of download failure, enhancing type safety.