Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for customizable conversation filenames. #1059

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Emt-lin
Copy link
Contributor

@Emt-lin Emt-lin commented Jan 16, 2025

Related:#1046#718

Rendering

CleanShot 2025-01-16 at 18 28 21

@archubbuck
Copy link

Excellent work!

@archubbuck
Copy link

@Emt-lin, once this is merged in by @logancyang, please send me your payment details so I can send you the bounty.

@Emt-lin
Copy link
Contributor Author

Emt-lin commented Jan 19, 2025

@Emt-lin, once this is merged in by @logancyang, please send me your payment details so I can send you the bounty.

Thank you. After the merger, just send the bounty to @logancyang, It's ok .

@archubbuck
Copy link

@Emt-lin, when do you think this might be merged?

@@ -502,6 +502,7 @@ export const DEFAULT_SETTINGS: CopilotSettings = {
numPartitions: 1,
enabledCommands: {},
promptUsageTimestamps: {},
defaultConversationNoteName: "{$date}_{$time}__{$topic}",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a backward-compatible pattern, right now it is {$topic}@{$date}_{$time}.

@logancyang logancyang merged commit 5ecfee7 into logancyang:master Jan 22, 2025
2 checks passed
@logancyang logancyang mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants