fix: run migrations in series #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slnode test please |
jannyHou
reviewed
Mar 16, 2020
| @@ -42,10 +44,17 @@ describe('sql connector', function() { | |||
| }); | |||
|
|
|||
| it('automigrate reports errors for models not attached', function(done) { | |||
| ds.automigrate(['m1', 'm2'], function(err) { | |||
| ds.automigrate(['m1', 'm3'], function(err) { | |||
There was a problem hiding this comment.
any reason change m2 to m3?
There was a problem hiding this comment.
Previously there was only a single table m1 attached and m2 was un-attached. The new test (line #55) expects two tables created in a series. So I refactored two tables m1 and m2 to be attached by default, and here to look for an un-attached table m3.
There was a problem hiding this comment.
Thank you for the explanation, fair enough.
|
Yes @jannyHou that would help, thank you. |
|
@slnode test please |
|
@klassicd, thanks for your contribution. Your PR has landed! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168
Replaces
async.eachwithasync.eachSeriesinautomigrate()andautoudate()so migrations are run in a series instead of in parallel. This enforces the model order so foreign key constructs with Postgres are possible.Previously it was impossible to enforce order in Loopback 4 using the
modelsoption tomigrateSchema({models: ['m1', 'm2']})as documented here https://loopback.io/doc/en/lb4/todo-list-tutorial-sqldb.htmlChecklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine