Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update todolist doc #1992

Merged
merged 1 commit into from
Nov 9, 2018
Merged

docs: update todolist doc #1992

merged 1 commit into from
Nov 9, 2018

Conversation

nabdelgadir
Copy link
Contributor

@nabdelgadir nabdelgadir commented Nov 7, 2018

Connect to #1908 and #1828.
Minor fixes in the documentation for the TodoList example, including adding lb4 repository command, and other miscellaneous updates.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

docs/site/todo-list-tutorial-controller.md Outdated Show resolved Hide resolved
docs/site/todo-list-tutorial-model.md Outdated Show resolved Hide resolved
@nabdelgadir nabdelgadir force-pushed the update-todolist-doc branch 6 times, most recently from 0fa083a to 6f0f392 Compare November 8, 2018 19:11
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpicks, otherwise LGTM 👍

- create `todo-list.repository.ts`
- update `index.ts` to export the newly created repository
From inside the project folder, run the `lb4 repository` command to create a
repository for the TodoList model using the `db` datasource. The `db` datasource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: TodoList -> TodoList

docs/site/Using-components.md Show resolved Hide resolved
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I am concerned. Please address comments left by other reviewers before landing.

@nabdelgadir nabdelgadir merged commit 75eba76 into master Nov 9, 2018
@nabdelgadir nabdelgadir deleted the update-todolist-doc branch November 9, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants