-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds MultiMethodDecoratorFactory #4417
Merged
raymondfeng
merged 6 commits into
loopbackio:master
from
mschnee:feat/multi-method-decorator-factory
Jan 15, 2020
Merged
feat: adds MultiMethodDecoratorFactory #4417
raymondfeng
merged 6 commits into
loopbackio:master
from
mschnee:feat/multi-method-decorator-factory
Jan 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
reviewed
Jan 14, 2020
raymondfeng
reviewed
Jan 14, 2020
raymondfeng
reviewed
Jan 14, 2020
raymondfeng
requested changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mschnee Great addition. Please address my comments.
Updates made- thanks for the quick feedback @raymondfeng ! |
raymondfeng
reviewed
Jan 14, 2020
raymondfeng
reviewed
Jan 14, 2020
raymondfeng
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements: #4300
See: #4406
This has been split from #4406 as a more manageable, smaller PR.
Added
@response
decorator, which will be split from feat: adds several convenience decorators #4406 into a separate pull request.Examples
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated