-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/complex-x-ts-types - Adds supports for using x-ts-type in anyOf
, allOf
, oneOf
, and not
keywords
#4479
feat/complex-x-ts-types - Adds supports for using x-ts-type in anyOf
, allOf
, oneOf
, and not
keywords
#4479
Conversation
anyOf
, allOf
, oneOf
, and not
keywords
1d5f452
to
b21092e
Compare
NOTE I've rebased and force-pushed my branch. I hope that addresses the travis-commitlint build errors, as I think that may have come in from pulling upstream. |
FYI - the drop in test coverage is in the |
:/ I'd love a little assistance in addressing this failing test. I don't believe the changes in this PR had any impact on the cloudant tests. |
@mschnee Please ignore the cloudant issue. |
I will update the documentation referring to |
Document updated :) |
@mschnee Please rebase your branch to latest master to pass CI tests. |
@mschnee Please follows instructions at https://loopback.io/doc/en/lb4/submitting_a_pr.html#6-rebasing for rebasing. |
88bca90
to
29c5a05
Compare
Rebase complete! :) |
@mschnee Thank you for cleaning up the PR. One last step - please squash two commits into one per instructions at https://loopback.io/doc/en/lb4/submitting_a_pr.html#10-final-rebase-and-squashing-of-commits. |
fa8b182
to
6594975
Compare
6594975
to
0c885e9
Compare
Rebased off of master this morning again and pushed :) |
Partially implements: #4300
See: #4406
This has been split from #4406 as a more manageable, smaller PR.
Added
This PR adds support for using
x-ts-type
schema bodies the value ofanyOf
,allOf
,oneOf
, andnot
schema object keys, as described by the OpenAPI Schema Object specification. In this exampleResponseObject
:Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated