[RFC] adopt contributor covenant v2 #4802
Conversation
achrinza
added
community-contribution
Contributing
|
Thank you @achrinza for the pull request. I don't have strong opinions on details about which form of code of conduct to adopt. @dhmlau @raymondfeng what's your take? Are we ok to adopt "Contributor Covenant v2"? Do we need to get any IBM-internal approvals for this change? |
| @@ -17,6 +17,9 @@ defer to the owners of each individual module; the powers of the individual | |||
| owner are kept in check by the ability of the community to fork and replace | |||
| dependencies on the individual module and maintainer. | |||
|
|
|||
| The LoopBack project adopts the | |||
| [Contributor Covenant version 2](CODE_OF_CONDUCT.md). | |||
There was a problem hiding this comment.
I think we will need to update the documentation in http://loopback.io/doc/en/contrib/index.html too.
achrinza
force-pushed
the
chore/adopt-cc2
branch
from
3612ba9 to
b4ac849
Compare
This is to steer the project to be more in-line with the expectations from the FOSS community, thereby increasing ease of adoption and contribution. Signed-off-by: Rifa Achrinza <[email protected]> chore: apply @bajtos' feedback replace naked email with a `mailto` link. see loopbackio#4802 (comment) Signed-off-by: Rifa Achrinza <[email protected]>
achrinza
force-pushed
the
chore/adopt-cc2
branch
from
b4ac849 to
3454c13
Compare
|
@raymondfeng , @dhmlau , your opinion on this? thanks. :) |
|
I need to find out what's the implications and recommendation from the IBM open source side. Will circle back. |
|
We just switch the contribution method from CLA to DCO, making your contribution easier in the future. Please sign the commits with DCO by amending your commit messages with Please refer to this docs page for details. Thanks! |
|
@dhmlau Any updates on your front? This PR is ready to go, just needs approval 😀 |
There was a problem hiding this comment.
LGTM as far as I am concerned. Please wait for an approval from @dhmlau and @raymondfeng before landing.
Thank you @achrinza for initiating this change!
This is to steer the project to be more in-line with the expectations from the FOSS community, thereby increasing ease of adoption and contribution. Signed-off-by: Rifa Achrinza <[email protected]> chore: apply @bajtos' feedback replace naked email with a `mailto` link. see loopbackio#4802 (comment) Signed-off-by: Rifa Achrinza <[email protected]>
achrinza
force-pushed
the
chore/adopt-cc2
branch
from
3454c13 to
9558fd1
Compare
|
@achrinza, could you please take a look at the commit linter issue? Thanks. |
This is to steer the project to be more in-line with the expectations from the FOSS community, thereby increasing ease of adoption and contribution. Signed-off-by: Rifa Achrinza <[email protected]>
achrinza
force-pushed
the
chore/adopt-cc2
branch
from
9558fd1 to
680d78d
Compare
|
Landed, thank you @achrinza again! Can you please take a look at the contrib docs on loopback.io (start with http://loopback.io/doc/en/contrib/index.html) and check what needs to be updated too? I think we should add a link to CODE OF CONDUCT to Governance Principles - see https://loopback.io/doc/en/contrib/Governance.html#principles. |
This PR consists of 1 commit:
Adopt Contributor Covenant v2
This is to steer the project to be more in-line with the expectations from the FOSS community, thereby increasing ease of adoption and contribution.
Electron, AMP, nvm, Node-RED are examples of Node.js projects that adopt the Contributor Covenant.
Signed-off-by: Rifa Achrinza [email protected]
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈