test(repository-tests): adding acceptance tests for hasManyThrough relation #5765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnes512
force-pushed
the
hmt-acpt-test
branch
2 times, most recently
from
7eb708d to
02380ed
Compare
jannyHou
approved these changes
Jun 29, 2020
packages/repository-tests/src/crud/relations/acceptance/has-many-through.relation.acceptance.ts
Show resolved
Hide resolved
|
|
||
| await expect( | ||
| customerRepo.cartItems(existingCustomerId).patch({id: anotherId}), | ||
| ).to.be.rejectedWith(/Property "id" cannot be changed!/); |
| expect(links).have.length(2); | ||
| expect(cartItems).have.length(2); | ||
|
|
||
| await customerRepo.cartItems(existingCustomerId).delete(); |
There was a problem hiding this comment.
nitpick: does delete takes in a filter? Maybe add another test for delete with filter
There was a problem hiding this comment.
Just realized that the delete method has a bug. It is able to delete targets based on the filter but it deletes all through instance that has the souceKey. Will open up an issue to fix it.
There was a problem hiding this comment.
The issue is being tracked in #5852
packages/repository-tests/src/crud/relations/acceptance/has-many-through.relation.acceptance.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4438 #2359
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈