Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move "db transactions" to "how-to guides" in sidebar #5779

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 19, 2020

This is a follow-up to #5718, see also #5549.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos force-pushed the docs/move-db-transactions branch from 2cd1246 to 854880e Compare June 22, 2020 07:18
@bajtos bajtos force-pushed the docs/move-db-transactions branch from 854880e to 485e049 Compare June 22, 2020 15:09
@bajtos bajtos requested review from raymondfeng and dhmlau June 22, 2020 15:10
@bajtos
Copy link
Member Author

bajtos commented Jun 22, 2020

Based on discussion with @raymondfeng, we will stick with Sentence-style.html to land my PRs and then normalize URL slugs afterwards, as this part may take a bit longer to reach consensus.

@bajtos bajtos merged commit 81c0a62 into master Jun 22, 2020
@bajtos bajtos deleted the docs/move-db-transactions branch June 22, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants