Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] feat(docs): aug milestone #5952

Closed
wants to merge 6 commits into from
Closed

[DO NOT MERGE] feat(docs): aug milestone #5952

wants to merge 6 commits into from

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Jul 16, 2020

August milestone

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau marked this pull request as draft July 16, 2020 23:39
@dhmlau dhmlau requested review from raymondfeng and bajtos July 16, 2020 23:39
bajtos
bajtos reviewed Jul 17, 2020
View reviewed changes
docs/_Aug_milestone_.md Outdated Show resolved Hide resolved
jannyHou
jannyHou reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dhmlau for creating the issue. I added a comment about the authorization doc improvement.
If we don't have the bandwidth to add the example repo next month, shall we add it in the stretch goal?

docs/_Aug_milestone_.md Show resolved Hide resolved
@dhmlau
Copy link
Member Author

dhmlau commented Jul 30, 2020

#6028 is opened. Closing this PR.

@dhmlau dhmlau closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannyHou jannyHou jannyHou left review comments

@bajtos bajtos bajtos approved these changes

@raymondfeng raymondfeng raymondfeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhmlau @raymondfeng @bajtos @jannyHou