Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add couchdb2 connector to database connector ref #6013

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

agnes512
Copy link
Contributor

@agnes512 agnes512 commented Jul 27, 2020

connects to #5267

Screen Shot 2020-07-27 at 2 05 54 PM

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@agnes512 agnes512 requested a review from dhmlau July 27, 2020 18:26
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the file corresponding to https://loopback.io/doc/en/lb4/Database-connectors.html too? Thanks.

@@ -664,6 +664,10 @@ children:
url: Cloudant-connector.html
output: 'web, pdf'

- title: 'CouchDB 2 connector'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clear to just have CouchDB connector

Suggested change
- title: 'CouchDB 2 connector'
- title: 'CouchDB connector'

SECURITY.md Outdated
@@ -19,6 +19,7 @@ LoopBack implements the
**Database connectors**

- [Cassandra connector](https://loopback.io/doc/en/lb4/Cassandra-connector.html)
- [CouchDB 2 connector](https://loopback.io/doc/en/lb4/Couchdb2-connector.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [CouchDB 2 connector](https://loopback.io/doc/en/lb4/Couchdb2-connector.html)
- [CouchDB connector](https://loopback.io/doc/en/lb4/Couchdb2-connector.html)

@agnes512
Copy link
Contributor Author

@dhmlau

Could you please update the file corresponding to https://loopback.io/doc/en/lb4/Database-connectors.html too?

The list of connectors is generated by the sidebar:
https://github.com/strongloop/loopback.io/blob/gh-pages/pages/en/lb4/Database-connectors.md

Btw the list is incorrect atm. My fix in https://github.com/strongloop/loopback.io/pull/976/files got reverted by the bot loopbackio/loopback.io@99dcc57 D:

@agnes512 agnes512 force-pushed the couchdb2-docs branch 2 times, most recently from 3db7ee3 to 59525b4 Compare July 28, 2020 15:13
SECURITY.md Outdated
@@ -19,6 +19,7 @@ LoopBack implements the
**Database connectors**

- [Cassandra connector](https://loopback.io/doc/en/lb4/Cassandra-connector.html)
- [CouchDB 2.x connector](https://loopback.io/doc/en/lb4/Couchdb2-connector.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a second thought, i'm thinking whether it's better to just have CouchDB connector, so that it's consistent with the other connector names.

@agnes512 agnes512 merged commit 4f6c598 into master Jul 28, 2020
@agnes512 agnes512 deleted the couchdb2-docs branch July 28, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants