fix(docs): rename legacy juggler to juggler #6037
Conversation
packages/repository/DEVELOPING.md
Outdated
| As mentioned before, we are using the legacy juggler bridge as a temporary | ||
| solution. This may change in the future since the Juggler is pretty.. you know, | ||
| legacy. However, it's important to realize how LB4 deals with models. | ||
| As mentioned before, we are using the juggler bridge as a temporary solution. |
There was a problem hiding this comment.
I think we'll need to rephrase this or even remove it altogether. @raymondfeng @bajtos thoughts?
There was a problem hiding this comment.
Updated, thanks!
nabdelgadir
force-pushed
the
rename-juggler
branch
from
f41c6b5 to
78f8727
Compare
There was a problem hiding this comment.
Thank you @nabdelgadir for the pull request. The changes look mostly good 👏🏻
I think we should take this opportunity and remove the experimental status, see my comments below.
packages/repository/README.md
Outdated
| @@ -6,8 +6,7 @@ This module provides a common set of interfaces for interacting with databases. | |||
|
|
|||
| **NOTE**: This module is experimental and evolving. It is likely going to be | |||
| refactored and decomposed into multiple modules as we refine the story based on | |||
| the legacy `loopback-datasource-juggler` and connector modules from LoopBack | |||
| 3.x. | |||
| `loopback-datasource-juggler` and connector modules from LoopBack 3.x. | |||
There was a problem hiding this comment.
I think @loopback/repository is no longer experimental. It's true that we are thinking about decompose this module into multiple smaller ones, but that's a very long term goal, far in the future.
I am proposing to remove this paragraph entirely.
packages/repository/src/index.ts
Outdated
| @@ -9,8 +9,7 @@ | |||
| * @remarks | |||
| * *NOTE:* This module is experimental and evolving. It is likely going to be | |||
| * refactored and decomposed into multiple modules as we refine the story based | |||
| * on the legacy loopback-datasource-juggler and connector modules from LoopBack | |||
| * 3.x. | |||
| * on the loopback-datasource-juggler and connector modules from LoopBack 3.x. | |||
There was a problem hiding this comment.
Ditto, let's remove the "experimental status" note.
nabdelgadir
force-pushed
the
rename-juggler
branch
from
78f8727 to
afc3a79
Compare
Fixes #5558
I also renamed it in the CLI.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈