-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: restructure the concepts page #6085
Conversation
keywords: LoopBack 4.0, LoopBack 4, Node.js, TypeScript, OpenAPI, Interceptor | ||
sidebar: lb4_sidebar | ||
permalink: /doc/en/lb4/Interceptors.html | ||
permalink: /doc/en/lb4/Interceptor.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand the rationale behind changing the html path name is to make it consistent with the title. If that's the case, can we keep the same html and add the redirect_to
? Renaming the html path will cause broken links in other docs or articles (mostly external ones, not part of LB docs). WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhmlau 👍 Fair enough, adding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jannyHou. Your PR LGTM in general. I have one concern about renaming the html path, please see https://github.com/strongloop/loopback-next/pull/6085/files#r468144288. Thanks.
I start to lean toward getting rid of
|
Thanks @raymondfeng fair enough, I moved them into "Core", see the updated doc: |
Are we changing the order in this PR? |
@agnes512 Thanks for the suggestion in #6085 (comment) good catch, and yes the order is changed as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9690f31
to
77ab2fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! ❤️
keywords: LoopBack 4.0, LoopBack 4, Node.js, TypeScript, OpenAPI, Concepts | ||
sidebar: lb4_sidebar | ||
permalink: /doc/en/lb4/Components.html | ||
permalink: /doc/en/lb4/Component.html | ||
redirect_from: /doc/en/lb4/Components.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to use singular form in permalink
and add redirect_from
to preserve existing links 👍🏻
connect to #5776
I renamed the concept items to use the singular terms.
fold subsections:
unfold subsections, part 1:
unfold subsections, part 2:
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈