Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): extract route how-to #6486

Merged
merged 1 commit into from
Oct 5, 2020
Merged

fix(docs): extract route how-to #6486

merged 1 commit into from
Oct 5, 2020

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Oct 2, 2020

Signed-off-by: Diana Lau [email protected]

Implements #6109.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau self-assigned this Oct 2, 2020
@dhmlau dhmlau added the Docs label Oct 2, 2020
nabdelgadir
nabdelgadir approved these changes Oct 2, 2020
View reviewed changes
docs/site/Customizing-routes.md Outdated Show resolved Hide resolved
docs/site/Customizing-routes.md Outdated Show resolved Hide resolved
@dhmlau dhmlau force-pushed the routes branch 2 times, most recently from 6cda212 to 1e7cab7 Compare October 3, 2020 01:53
bajtos
bajtos approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 with a couple of minor comments to consider.

docs/site/sidebars/lb4_sidebar.yml Outdated Show resolved Hide resolved
docs/site/Route.md Outdated Show resolved Hide resolved
@dhmlau dhmlau merged commit 90d8a88 into master Oct 5, 2020
@dhmlau dhmlau deleted the routes branch October 5, 2020 14:05
@dhmlau dhmlau mentioned this pull request Oct 5, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@bajtos bajtos bajtos approved these changes

Assignees

@dhmlau dhmlau

Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhmlau @bajtos @nabdelgadir