Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): refactor docs to create artifacts at runtime #6732

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Nov 5, 2020

Signed-off-by: Diana Lau [email protected]

Related to #5783.

There are docs for creating LoopBack artifacts at runtime, so I created a separate how-to sidebar item.

Screen Shot 2020-11-04 at 7 59 44 PM

There are some clean up that's probably needed for the Repository and DataSource page, but i'd keep this PR smaller and for refactoring.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau added the Docs label Nov 5, 2020
@dhmlau dhmlau self-assigned this Nov 5, 2020
Copy link
Contributor

@nabdelgadir nabdelgadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks but LGTM

docs/site/Creating-model-runtime.md Outdated Show resolved Hide resolved
docs/site/Creating-datasource-runtime.md Outdated Show resolved Hide resolved
docs/site/sidebars/lb4_sidebar.yml Outdated Show resolved Hide resolved
@dhmlau dhmlau merged commit 510ba91 into master Nov 9, 2020
@dhmlau dhmlau deleted the runtime branch November 9, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants