fix expected 404 error message in VLANs and subnet tests

lord-kyron · Feb 26, 2024 · 810809c · 810809c
1 parent b5d7169
commit 810809c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/plugin/providers/phpipam/resource_phpipam_subnet_test.go b/plugin/providers/phpipam/resource_phpipam_subnet_test.go
@@ -153,10 +153,11 @@ func testAccCheckResourcePHPIPAMSubnetCreated(s *terraform.State) error {
 func testAccCheckResourcePHPIPAMSubnetDeleted(s *terraform.State) error {
 	subnetController := testAccProvider.Meta().(*ProviderPHPIPAMClient).subnetsController
 	_, err := subnetController.GetSubnetsByCIDRAndSection(testAccResourcePHPIPAMSubnetCIDR, testAccResourceSubnetPHPIPAMSectionID)
+	error_messages := linearSearchSlice{"Error from API (404): No results (filter applied)", "Error from API (404): No subnets found"}
 	switch {
 	case err == nil:
 		return errors.New("Expected error, got none")
-	case err != nil && err.Error() != "Error from API (404): No results (filter applied)":
+	case err != nil && !error_messages.Has(err.Error()):
 		return fmt.Errorf("Expected 404, got %s", err)
 	}
 

diff --git a/plugin/providers/phpipam/resource_phpipam_vlan_test.go b/plugin/providers/phpipam/resource_phpipam_vlan_test.go
@@ -148,10 +148,11 @@ func testAccCheckResourcePHPIPAMVLANCreated(s *terraform.State) error {
 func testAccCheckResourcePHPIPAMVLANDeleted(s *terraform.State) error {
 	c := testAccProvider.Meta().(*ProviderPHPIPAMClient).vlansController
 	_, err := c.GetVLANsByNumberAndDomainID(testAccResourcePHPIPAMVLANNumber, testAccResourceVlanPHPIPAML2DomainID)
+	error_messages := linearSearchSlice{"Error from API (404): No results (filter applied)", "Error from API (404): Vlans not found"}
 	switch {
 	case err == nil:
 		return errors.New("Expected error, got none")
-	case err != nil && err.Error() != "Error from API (404): No results (filter applied)":
+	case err != nil && !error_messages.Has(err.Error()):
 		return fmt.Errorf("Expected 404, got %s", err)
 	}