-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Section and Vlan import feature #88
Conversation
Hi @peterbaumert Currently this PR has errors during build:
To fix errors make this changes:
Also, please rebase commits in this PR to the single commit. |
Update data_source_phpipam_section.go as suggested by pavel-z1 Update data_source_phpipam_vlan.go as suggested by pavel-z1
@pavel-z1 added your changed and did a single commit. |
would you mind having a look at this @pavel-z1 ? |
Hi @peterbaumert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ty @pavel-z1 could you also generate a new release? |
@peterbaumert I will generate a new release when the last 3 pull requests currently pending get approved and merged. |
Okay sounds good. Thanks for the info! |
@lord-kyron could you generate the release? :) |
@peterbaumert new release was generated. Enjoy! |
I'm neither a go expert nor an terraform expert. I simply copied and edited from other files so please check :)