-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make trustbadge container responsive phone, tablet #27
make trustbadge container responsive phone, tablet #27
Conversation
2nd Commit: Refactor FirstContainer.js@EugeneGohh I have gone into FirstContainer.js and refactored a lot of the code. I did change a lot, but if you don't like it or it wasn't what you intended then please feel free to discard or tweak any of the changes.
|
Looks good we just need to get the spacing between those items (each avatar/pic) in this container. That's what I was hoping to accomplish with the |
It has been a few days. I have cleaned up some code during my free time. Here is an overview of what I have done for the past few days working on this PR. It looks good for now our site.
I will reply as soon as possible to your Discord messages maybe tomorrow morning. |
Make Responsive TrustBadgeContainer.js
I have updated TrustBadgeContainer.js and TrustBadgeContainerStyles.js to be responsive on all viewports including mobile & tablet sizes.
On mobile sizes their will be 1 column for the image containers in the grid
On tablet sizes, their will be 2 columns for the image containers in the grid
Additionally on size "sm" (tablet down to mobile screens) I have added a padding-bottom of 10vh. @EugeneGohh no idea if adding this CSS prop is considered good practice but at least it works for now. I left a message in Discord but I think we should try standardizing how we want containers to have margins or padding so that there is a nice visual spacing/separation between containers