Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twillo SMS Alerts #1860

Closed
1 task done
SecureCPU opened this issue Jun 30, 2022 · 7 comments
Closed
1 task done

Twillo SMS Alerts #1860

SecureCPU opened this issue Jun 30, 2022 · 7 comments
Labels
feature-request Request for new features to be added

Comments

@SecureCPU
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

New Notification

🔖 Feature description

Receiving notification via SMS with Twilio

✔️ Solution

Add Twillo as a SMS option for Notifications

❓ Alternatives

No response

📝 Additional Context

No response

@SecureCPU SecureCPU added the feature-request Request for new features to be added label Jun 30, 2022
@phanxgames
Copy link

This would be awesome.

@lctech-zeki
Copy link

plz i need this feat

@krisdahl
Copy link

+1

@woj-tek
Copy link
Contributor

woj-tek commented May 26, 2023

Hmm... I'm on a latest Kuma and I see Twilio option so it seems it's already there?

However, I would like to add/ask option to log-in via API Key instead of using master AccountSID and AuthToken. See https://www.twilio.com/docs/usage/requests-to-twilio#creating-or-updating-resources-with-the-post-method

Basically one can either use const client = require('twilio')(accountSid, authToken); or const client = require('twilio')(apiKey, apiSecret, { accountSid: accountSid });, where the second one is more secure and thus recomended.

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented May 27, 2023

@woj-tek
Any PR adding such functionality is likely to be added to master.

  • please also go into detail what you mean by "more secure and thus recommended"
  • The problem with the notification providers is, that they are for the most part untested/untestable.
    => Screenshots are needed to verify that this change works.

needed change (using curl, as imo this is more readable):
image

@CommanderStorm
Copy link
Collaborator

@SecureCPU given that this is in uptime kuma since #2980 (this issue was a duplicate => was missed in the autocloing), please close this issue 😅
image

@woj-tek
Copy link
Contributor

woj-tek commented May 29, 2023

@CommanderStorm considering this issue got closed I went with followup: #3204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

6 participants