Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twilio Sms Notification Provider #2980

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

Genc
Copy link
Contributor

@Genc Genc commented Mar 25, 2023

  • I have read and understand the pull request rules.

Description

You can receive notifications in the form of SMS via Twilio. All you need for this is a Twilio account. (Account SID, Auth Token, Phone Number) You can create a new account here. https://www.twilio.com

Feature Request #2964

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

SetupNotification

sms

Twilio

@louislam louislam merged commit 4869e65 into louislam:master Mar 26, 2023
@uranderu
Copy link

Might I ask why you use "let" for variables you never mutate? Why don't you use "const"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants