Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from omsrivastava/timezones-list to vvo/tzdb #4479

Closed
chakflying opened this issue Feb 11, 2024 · 2 comments · Fixed by #4521
Closed

Migrate from omsrivastava/timezones-list to vvo/tzdb #4479

chakflying opened this issue Feb 11, 2024 · 2 comments · Fixed by #4521
Labels
area:settings Related to Settings page and application configration feature-request Request for new features to be added help wanted May need your help to test or answer

Comments

@chakflying
Copy link
Collaborator

chakflying commented Feb 11, 2024 •
edited
Loading

📑 I have found these related issues/pull requests

none

🏷️ Feature Request Type

Other

🔖 Feature description

omsrivastava/timezones-list, the library currently used by our front-end, is rarely updated and has inaccuracies.

vvo/tzdb looks much better as it is automatically kept up-to-date with authoritative sources.

Some migration work is needed since the data format is different.

✔️ Solution

Migrate from omsrivastava/timezones-list to vvo/tzdb

❓ Alternatives

No response

📝 Additional Context

No response
@chakflying chakflying added feature-request Request for new features to be added area:settings Related to Settings page and application configration labels Feb 11, 2024
@CommanderStorm CommanderStorm added the help wanted May need your help to test or answer label Feb 12, 2024
@louislam
Copy link
Owner

It can be considered as a bug fix, because the omsrivastava/timezones-list#14 issue you mentioned should be related to the DST issue, which timezones-list does not handling it at all.

https://www.zeitverschiebung.net/en/timezone/america--santiago

@huzaifaazim0 huzaifaazim0 mentioned this issue Feb 23, 2024
Merged
7 tasks
@huzaifaazim0
Copy link
Contributor

created a pull requestwith migrated lib
#4521

louislam pushed a commit that referenced this issue Mar 3, 2024
@huzaifaazim0
migrate timezones-list lib to @vvo/tzdb issue #4479 (#4521)
8fd713d
@CommanderStorm CommanderStorm mentioned this issue Mar 5, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:settings Related to Settings page and application configration feature-request Request for new features to be added help wanted May need your help to test or answer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate timezones-list lib to @vvo/tzdb issue #4479 huzaifaazim0/uptime-kuma
4 participants
@louislam @chakflying @CommanderStorm @huzaifaazim0