Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds name + status + message to Slack notification #2736

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

blozano824
Copy link
Contributor

@blozano824 blozano824 commented Feb 8, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #2706 by taking the existing message displayed using Block Kit and including it in the text to provide a more detailed Slack notification.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Slack Notification When Up

image

Slack Notification When Down

image

Slack Messages In Channel

image

@blozano824 blozano824 marked this pull request as ready for review February 8, 2023 03:17
@louislam louislam added this to the 1.21.0 milestone Feb 15, 2023
@louislam louislam merged commit e873fea into louislam:master Feb 24, 2023
@blozano824 blozano824 deleted the add-status-to-slack-notification branch February 24, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add status to slack notification title
2 participants