Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use ApiKeys in Twilio in addition to main account credentials #3205

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

woj-tek
Copy link
Contributor

@woj-tek woj-tek commented May 30, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This PR extends functionality of Twilio notification to use either main AccountSID and AuthToken or dedicated ApiKey and ApiKey secret, which improves security (ApiKeys have less permissions and can be easily revoked at any time)

Fixes #3204

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • Other
  • This change requires a documentation update (not sure)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

@CommanderStorm mentioned: "=> Screenshots are needed to verify that this change works." - how would I provide that? And screenshot from my sms app?

@CommanderStorm
Copy link
Collaborator

For screenshots yes, any screenshots after configuring it with the change you did
(Remember to block out sensitive content like phone number, API keys)
See #3176 for an example

@woj-tek
Copy link
Contributor Author

woj-tek commented May 30, 2023

Uptime-Kuma Twilio notification settings (no data):

Captura de pantalla 2023-05-30 a las 11 07 45

Recieved (test) notifications:
kuma-twilio-sms

(I hope it's ok)

@louislam louislam added this to the 1.23.0 milestone Jun 24, 2023
@louislam louislam merged commit e5c6783 into louislam:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use API key in Twilio to improve security
3 participants