Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification-dingding): throw error when failed #3598

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

AnnAngela
Copy link
Contributor

@AnnAngela AnnAngela commented Aug 18, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

See #3573 (comment)

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

#3598 (comment)

@CommanderStorm
Copy link
Collaborator

Have you tested that this works as intended?
Could you attach a screenshot as above of the monitor failing? (#3573 (comment)) ^^

@AnnAngela
Copy link
Contributor Author

Have you tested that this works as intended?
Could you attach a screenshot as above of the monitor failing? (#3573 (comment)) ^^

OK, I will try to get the screenshot next Monday. (I'm on vacation.)

@louislam louislam added this to the 1.23.1 milestone Aug 18, 2023
@louislam louislam modified the milestones: 1.23.1, Pending Sep 8, 2023
@chakflying chakflying added area:notifications Everything related to notifications question Further information is requested labels Dec 2, 2023
@CommanderStorm
Copy link
Collaborator

@AnnAngela ping ^^

@AnnAngela
Copy link
Contributor Author

AnnAngela commented Jan 19, 2024

@CommanderStorm Sorry for late response, I forgot it :(

In this PR branch (wrong SecretKey used):

E1

In the stable version (falsely success msg):

E2

@CommanderStorm CommanderStorm modified the milestones: Pending, 1.23.12 Jan 19, 2024
@CommanderStorm CommanderStorm removed the question Further information is requested label Jan 19, 2024
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jan 19, 2024

@AnnAngela Thanks a ton 🎉

@louislam FYI: I put this into the 1.23.12 milestone as I think this meets our requirements (only bugfixes) for said release and can be merged without more indepth reveiew as the "proof of working" we need is there ^^

@louislam louislam changed the base branch from master to 1.23.X January 19, 2024 19:28
@louislam louislam merged commit b4e45c7 into louislam:1.23.X Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants