-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add stat_hourly
& min. max. ping
#4267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
chakflying
changed the title
Feat: Add stat_hourly & min. max. ping
Feat: Add Dec 22, 2023
stat_hourly
& min. max. ping
chakflying
added
area:metrics
related to monitoring metrics
area:core
issues describing changes to the core of uptime kuma
labels
Dec 22, 2023
CommanderStorm
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The switching is a bit messy but there is no good way to solve this other than the current solution afaik
Co-authored-by: Frank Elsinga <[email protected]>
golibnarzullayev
suggested changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if check should be written short
golibnarzullayev
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:core
issues describing changes to the core of uptime kuma
area:metrics
related to monitoring metrics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Decided to break out database and
UptimeCalculator
changes from #4264.stat_hourly
tableping_min
andping_max
columns to the stat tablesUptimeCalculator
to store these valuesupdate()
functionif (dailyData.up === 1) {
Type of change
Checklist
Screenshots (if any)