fix: Update axios, @actions/github and dompurify [1.23.X]
#4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No `package-lock.json` refresh, no other changes in `package.json`. 11 vulnerabilities with 1 critical...
CommanderStorm
requested changes
Apr 4, 2024
There was a problem hiding this comment.
I don't quite get why #4647 was closed, anyway.
These are the relevant parts of #4647 (review)
Saibamen
changed the title
axios, axios-ntlm, @actions/github and dompurify [1.23.X]axios, @actions/github and dompurify [1.23.X]
What u mean by deleting |
|
Ohh for recreating got it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11 vulnerabilities (1 low, 4 moderate, 5 high, 1 critical)EDIT:
13 vulnerabilities (1 low, 6 moderate, 5 high, 1 critical)instead of
14 vulnerabilities (1 low, 7 moderate, 5 high, 1 critical)Replaces PR #4647
Other vulnerabilities (and critical 9.8 CVSS GHSA-fqg8-vfv7-8fj8) could be fixed by simply deleting
package-lock.jsonand doingnpm update, but this is too much for PR. This was done by @louislam many times in the past...Vite should be updated to
4.5.3to fixfs.denyhigh vulnerability (7.5/10 CVSS score) (currently we are using4.4.12in 1.23.X branch).