Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneSender Webhook notification #4971

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

hasanbasri1993
Copy link
Contributor

@hasanbasri1993 hasanbasri1993 commented Jul 30, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #(issue)

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to not work as expected)
  • Other
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Event Before After
UP - image
DOWN - image
Certificate-expiry - image
Testing - image

@CommanderStorm CommanderStorm added the area:notifications Everything related to notifications label Jul 30, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good.

Could you please attach the screenshots we request in the contribution guide?
I have attached a template to the PR-Description.
The reason why we require this is that verififying that these notification providers is quite time-consuming for us and somewhat simple for you (as you already tested it).

src/components/notifications/Onesender.vue Outdated Show resolved Hide resolved
src/components/notifications/Onesender.vue Show resolved Hide resolved
@CommanderStorm CommanderStorm added the pr:please address review comments this PR needs a bit more work to be mergable label Jul 30, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(There are a few changes that I am going to do, but those are "editorial comments")

Thanks for the new notification provider! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

src/components/notifications/Onesender.vue Outdated Show resolved Hide resolved
src/components/notifications/Onesender.vue Outdated Show resolved Hide resolved
src/components/notifications/Onesender.vue Outdated Show resolved Hide resolved
src/components/notifications/Onesender.vue Outdated Show resolved Hide resolved
src/lang/en.json Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm merged commit 92e982a into louislam:master Aug 8, 2024
18 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants