Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to monitor #939

Merged

Conversation

jcvincenti
Copy link
Contributor

Description

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User Interface
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Translation update
  • Other
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and test it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Monitor description

Please do not use any external image service. Instead, just paste in or drag and drop the image here and it will be uploaded automatically.

@chakflying
Copy link
Collaborator

Tested backup and restore also works fine. But the Info icon shows even if there is no description. I'm also not sure if that icon fits the current design very well.

@jcvincenti jcvincenti force-pushed the feature/482-add-description-to-monitor branch from 5791e4e to 1de6b87 Compare November 25, 2021 21:30
@jcvincenti
Copy link
Contributor Author

@chakflying I have just added the conditional rendering to both the paragraph and the icon.
The info icon I'm using is from fontawesome, like the others. Maybe I can modify the color of the button to either gray (like the "Edit" button) or green (like the "Add new monitor" button). What do you think? Do you have any other button style in mind?

* Add description to monitor model
* Add description field to database
* Add english and spanish translation for description
* Closes: louislam#482
* Modify Details component
* Modify MonitorList component
@jcvincenti jcvincenti force-pushed the feature/482-add-description-to-monitor branch from 1de6b87 to fbf2df9 Compare December 14, 2021 22:15
@Saibamen
Copy link
Contributor

@louislam ping

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

We are clearing up our old Pull Requests and yours has been open for 3 months with no activity. Remove stale label or comment or this will be closed in 2 days.

@github-actions github-actions bot added the Stale label Dec 5, 2022
@louislam louislam removed the Stale label Dec 5, 2022
@louislam louislam added this to the 1.21.0 milestone Jan 2, 2023
…cription-to-monitor

# Conflicts:
#	server/database.js
#	server/model/monitor.js
#	src/icon.js
#	src/languages/en.js
#	src/languages/es-ES.js
@louislam louislam merged commit a80f228 into louislam:master Feb 25, 2023
@@ -1,4 +1,9 @@
module.exports = {
ignorePatterns: [
"test/*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want our tests to have ESLINT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Description to Monitor on Status Page
4 participants