-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description to monitor #939
Add description to monitor #939
Conversation
Tested backup and restore also works fine. But the Info icon shows even if there is no description. I'm also not sure if that icon fits the current design very well. |
5791e4e
to
1de6b87
Compare
@chakflying I have just added the conditional rendering to both the paragraph and the icon. |
* Add description to monitor model * Add description field to database * Add english and spanish translation for description * Closes: louislam#482
* Modify Details component * Modify MonitorList component
1de6b87
to
fbf2df9
Compare
@louislam ping |
We are clearing up our old Pull Requests and yours has been open for 3 months with no activity. Remove stale label or comment or this will be closed in 2 days. |
…cription-to-monitor # Conflicts: # server/database.js # server/model/monitor.js # src/icon.js # src/languages/en.js # src/languages/es-ES.js
@@ -1,4 +1,9 @@ | |||
module.exports = { | |||
ignorePatterns: [ | |||
"test/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want our tests to have ESLINT!
Description
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here and it will be uploaded automatically.