Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depedency typeguard #260

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

jasle
Copy link
Contributor

@jasle jasle commented May 8, 2024

Resolves #250

@jasle jasle force-pushed the update_dep_typeguard branch from 319f6e8 to 5923a8b Compare May 8, 2024 14:53
@jasle jasle changed the title Removed maximum version from typeguard dependency Update depedency typeguard May 8, 2024
@jasle
Copy link
Contributor Author

jasle commented May 8, 2024

cc @LostInDarkMath

@lovasoa
Copy link
Owner

lovasoa commented May 8, 2024

looks like this breaks the tests

@jasle jasle force-pushed the update_dep_typeguard branch from 5923a8b to 78b55aa Compare May 8, 2024 21:16
@jasle
Copy link
Contributor Author

jasle commented May 8, 2024

looks like this breaks the tests

It does not directly break the tests, but typeguard 4.0.0 requires at least python 3.7.4, so the building on ubuntu with python 3.6 does not work.

I adjusted the required version in this PR, but so this does not fix #250 for all specified python versions for this project.

Is dropping the support for older python versions an option?
typeguard 4.0.0 requires at least python 3.7.4, the current version of marshmallow python 3.8.

@lovasoa
Copy link
Owner

lovasoa commented May 9, 2024

Yes, that would be okay! Can you open a pr?

@lovasoa lovasoa merged commit c9d407c into lovasoa:master May 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union with generic types is broken
2 participants