Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

love.video support #175

Merged
merged 20 commits into from
Apr 23, 2022
Merged

love.video support #175

merged 20 commits into from
Apr 23, 2022

Conversation

TurtleP
Copy link
Collaborator

@TurtleP TurtleP commented Mar 29, 2022

Summary of the Pull Request

This adds support for the love.video module.

Validation Steps

  • Tested on 3DS
  • Tested on Switch

Checklist

  • Closes # NA
  • Successfully builds

Screenshots

N/A

Additional Details

This is going to be marked as a draft right now. The 3DS version of stuff works, but it appears the Switch crashes trying to decode theora packets. Not sure what that's about, given the code between the consoles for TheoraStream is basically the same.

@TurtleP TurtleP marked this pull request as ready for review April 1, 2022 02:57
@TurtleP
Copy link
Collaborator Author

TurtleP commented Apr 1, 2022

Everything works, but will not be merged until switch-theora is upgraded which fixes crashing on th_decode_packetin.

@TurtleP TurtleP merged commit a15ad42 into main Apr 23, 2022
@TurtleP TurtleP deleted the dev/video branch April 23, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant