Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsvg: improve zune-jpeg workaround #261

Closed

Conversation

kleisauke
Copy link
Collaborator

No description provided.

@lovell
Copy link
Owner

lovell commented Dec 12, 2024

Are the build failures due to multiple/conflicting versions of zune-core in the dependency tree?

2024-12-12T13:06:23.6334763Z Compiling zune-core v0.4.11 (https://github.com/etemesi254/zune-image.git?rev=80e1957#80e19571)
...
2024-12-12T13:06:29.1246132Z Compiling zune-core v0.4.12

@kleisauke
Copy link
Collaborator Author

Indeed, that's weird. It looks like I didn't test it properly before submitting this.

wasm-vips takes a similar approach, which seems to work well, but that uses resvg instead.
https://github.com/kleisauke/wasm-vips/blob/3f143eca218043d53dcd17b765419731030c5075/build.sh#L450-L457

I'll abandon this PR and add a note to etemesi254/zune-image#242.

@kleisauke kleisauke closed this Dec 12, 2024
@kleisauke kleisauke deleted the rsvg-improve-zune-jpeg-workaround branch December 12, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants