[pentest] Split FPGA firmware #26285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
added
the
CherryPick:earlgrey_1.0.0
pamaury
approved these changes
Feb 13, 2025
a-will
reviewed
Feb 14, 2025
| srcs = [":firmware_fi.c"], | ||
| exec_env = { | ||
| "//hw/top_earlgrey:silicon_owner_sival_rom_ext": "silicon_owner", | ||
| "//hw/top_earlgrey:sim_dv": None, | ||
| "//hw/top_earlgrey:fpga_cw310_test_rom": None, |
There was a problem hiding this comment.
Is this supposed to be tested in CI? If so, it looks like it needs substantially longer than 60 seconds.
If not, the FPGA params need a "manual" tag.
Same for the other opentitan_test() targets that have CW310 added.
There was a problem hiding this comment.
Due to size constraints, this commit splits the pentest framework into a SCA, FI, and FI OTBN part. Signed-off-by: Pascal Nasahl <[email protected]>
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-26285-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-26285-to-earlgrey_1.0.0
git switch --create backport-26285-to-earlgrey_1.0.0
git cherry-pick -x 034e3cf69744dc48501eb2c6e5699a880a8ba977 |
github-actions
bot
added
the
Manually CherryPick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to size constraints, this commit splits the pentest framework into a SCA, FI, and FI OTBN part.