Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add analysis of endpoint connections config file #9238

Merged

Conversation

Jan-Thurner
Copy link
Contributor

@Jan-Thurner Jan-Thurner commented Aug 21, 2024

Checklist

General

Motivation and Context

When new Language features are introduced, the libraries used for parsing need some time to adapt to them. To be able to use the tool in the meantime, files with new language features may be excluded from the analysis.

Description

A configuration file is added that allows the exclusion of client and server files from the analysis, as well as the exclusion of individual REST calls and endpoints.

Testing Steps

An up-to-date run of the workflow with all the excluded files, REST calls and endpoints can be found here: https://github.com/ls1intum/Artemis/actions/runs/11406939982

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2
  • Code Review 3
  • Code Review 4

Test Coverage

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced error handling and reporting for endpoint and REST call analyses.
    • Introduced a configuration management system for endpoint analysis, allowing for dynamic exclusion of files and endpoints.
    • Added support for YAML configuration files in both Java and TypeScript scripts.
  • Bug Fixes

    • Improved handling of mismatched endpoints and REST calls during analysis.
  • Documentation

    • Updated configuration file handling in the TypeScript client for better path management.
  • Chores

    • Added new dependencies for YAML handling in both Java and TypeScript environments.

Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 29, 2024
@github-actions github-actions bot removed the stale label Sep 8, 2024
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 16, 2024
@github-actions github-actions bot removed the stale label Sep 28, 2024
…t/AnalysisOfEndpointConnectionsConfigFile

# Conflicts:
#	supporting_scripts/analysis-of-endpoint-connections/src/main/java/de/tum/cit/endpointanalysis/EndpointAnalyzer.java
#	supporting_scripts/analysis-of-endpoint-connections/src/main/java/de/tum/cit/endpointanalysis/EndpointParser.java
#	supporting_scripts/analysis-of-endpoint-connections/src/main/java/de/tum/cit/endpointanalysis/RestCallAnalyzer.java
@github-actions github-actions bot removed the config-change Pull requests that change the config in a way that they require a deployment via Ansible. label Oct 14, 2024
@Jan-Thurner Jan-Thurner added the config-change Pull requests that change the config in a way that they require a deployment via Ansible. label Oct 14, 2024
@github-actions github-actions bot removed the config-change Pull requests that change the config in a way that they require a deployment via Ansible. label Oct 18, 2024
Copy link
Contributor

@raffifasaro raffifasaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approval

Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove 👍

@krusche krusche merged commit 1b8ad60 into develop Oct 19, 2024
21 of 25 checks passed
@krusche krusche deleted the feature/development/AnalysisOfEndpointConnectionsConfigFile branch October 19, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants