-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Add search and sort to course overview
#9316
Conversation
Pull latest changes
Pull latest changes
Pull latest changes
pull latest changes
Pull latest changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- src/main/webapp/app/overview/courses.component.html (2 hunks)
🧰 Additional context used
🔇 Additional comments (1)
src/main/webapp/app/overview/courses.component.html (1)
Line range hint
22-82
: Use of@if
and@for
directives adheres to coding guidelinesThe template correctly uses the
@if
and@for
directives instead of the old*ngIf
and*ngFor
syntax, in line with the provided coding guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retested on ts6, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts5, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Lgtm
General
: Add Search and Sort to Course OverviewGeneral
: Add search and sort to course overview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapprove
Checklist
General
Client
Motivation and Context
Course cards are redesigned to have a more clear and user-friendly course overview page. However, course overview still lacks of basic functionilities such as search and sort.
Description
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Screenshots
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes