Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Add search and sort to course overview #9316

Merged
merged 47 commits into from
Oct 11, 2024

Conversation

edkaya
Copy link
Contributor

@edkaya edkaya commented Sep 15, 2024

Checklist

General

Client

  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

Course cards are redesigned to have a more clear and user-friendly course overview page. However, course overview still lacks of basic functionilities such as search and sort.

Description

  • Added searchbar component
  • Added sort button to sort courses in alphatical order
  • Added the number of courses

Steps for Testing

Prerequisites:

  • 1 Student
  • Some courses
  1. Log in to Artemis
  2. Navigate to Course Overview
  3. Verify that search works as expected
  4. Verify that sort button sorts the courses by their titles in ascending/descending order

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Screenshot 2024-10-05 at 00 25 45

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Enhanced course overview with dynamic title displaying total course counts.
    • Added sorting functionality for courses, allowing users to toggle between ascending and descending order.
    • Integrated a search filter component for improved user interaction.
    • Updated course card layout for better visual consistency.
  • Bug Fixes

    • Improved conditional rendering for displaying messages when no courses are available.

edkaya and others added 30 commits July 23, 2024 02:21
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 47bc419 and 8475d57.

📒 Files selected for processing (1)
  • src/main/webapp/app/overview/courses.component.html (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/main/webapp/app/overview/courses.component.html (1)

Pattern src/main/webapp/**/*.html: @if and @for are new and valid Angular syntax replacing *ngIf and *ngFor. They should always be used over the old style.

🔇 Additional comments (1)
src/main/webapp/app/overview/courses.component.html (1)

Line range hint 22-82: Use of @if and @for directives adheres to coding guidelines

The template correctly uses the @if and @for directives instead of the old *ngIf and *ngFor syntax, in line with the provided coding guidelines.

Copy link
Member

@farisd16 farisd16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retested on ts6, works as expected

Copy link
Contributor

@asliayk asliayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapprove

Copy link
Member

@BBesrour BBesrour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ts5, lgtm

Copy link
Contributor

@SimonEntholzer SimonEntholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Lgtm

@rabeatwork rabeatwork added ready to merge maintainer-approved The feature maintainer has approved the PR and removed ready for review labels Oct 9, 2024
@edkaya edkaya added this to the 7.6.0 milestone Oct 9, 2024
@edkaya edkaya changed the title General: Add Search and Sort to Course Overview General: Add search and sort to course overview Oct 9, 2024
Copy link
Contributor

@yassinsws yassinsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) maintainer-approved The feature maintainer has approved the PR ready to merge tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants