Development: Remove redundant architecture test in atlas module

[MaximilianAnzinger]

Checklist

General

• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
• I strictly followed the server coding and design guidelines.
• I documented the Java code using JavaDoc style.

Motivation and Context

Description

Removes old TestArchitectureTest that got replaced by AtlasTestArchitectureTest.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Test Coverage

unchanged

Summary by CodeRabbit

• Bug Fixes

  • Removed automatic injection of the CompetencyProgressService in the integration test class to improve dependency management.

• Chores

  • Deleted the TestArchitectureTest class to streamline architectural testing processes and eliminate redundancy.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the AbstractAtlasIntegrationTest class by removing the @Autowired annotation for the competencyProgressService field, thereby altering its dependency injection behavior. Additionally, the TestArchitectureTest class, which enforced architectural rules related to integration tests, has been deleted. This impacts how integration tests are structured and the rules governing their dependencies.

Changes

File Path	Change Summary
src/test/java/de/tum/cit/aet/artemis/atlas/AbstractAtlasIntegrationTest.java	Removed @Autowired annotation from protected CompetencyProgressService competencyProgressService;.
src/test/java/de/tum/cit/aet/artemis/atlas/architecture/TestArchitectureTest.java	Removed class TestArchitectureTest, which contained architectural tests for integration test structure.

Possibly related PRs

• Development: Refactor atlas tests #9352: This PR involves the removal of @Autowired annotations from the LearningPathIntegrationTest, including the CompetencyProgressService, which is directly related to the changes made in the AbstractAtlasIntegrationTest class in the main PR.
• Development: Refactor lti tests #9375: The introduction of architectural rules in this PR includes a method that checks for the absence of @Autowired members in classes extending AbstractAtlasIntegrationTest, which aligns with the changes made in the main PR regarding the removal of the @Autowired annotation.
• Development: Execute architecture tests on module basis #9409: This PR enhances the modularization of the project and includes architectural tests that ensure compliance with the design principles, which are relevant to the changes made in the main PR regarding the structure of integration tests.
• Development: Fix server test compilation #9421: Although primarily focused on fixing compilation issues, this PR's context of modifying tests related to competencies may indirectly relate to the changes in dependency management seen in the main PR.

Suggested labels

tests, ready for review, atlas, bugfix

Suggested reviewers

• JohannesStoehr
• SimonEntholzer

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between eee133f and 2a400fe.

📒 Files selected for processing (2)

• src/test/java/de/tum/cit/aet/artemis/atlas/AbstractAtlasIntegrationTest.java (0 hunks)
• src/test/java/de/tum/cit/aet/artemis/atlas/architecture/TestArchitectureTest.java (0 hunks)

💤 Files with no reviewable changes (2)

• src/test/java/de/tum/cit/aet/artemis/atlas/AbstractAtlasIntegrationTest.java
• src/test/java/de/tum/cit/aet/artemis/atlas/architecture/TestArchitectureTest.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.