Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add replay integration for sentry #369

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Conversation

thielpa
Copy link
Contributor

@thielpa thielpa commented Feb 14, 2025

🪩 Open for discussion: This sentry integration helps reproducing the errors and debugging it with replaying the users behaviour in the moment the bug appears. IMO this improves our capabilities and helps us fix bugs in production faster and easier. What do you think @egekocabas @StefanNemeth @TurkerKoc @gbanu?

Find more infos here: https://sentry.io/product/session-replay/

@thielpa thielpa requested a review from a team as a code owner February 14, 2025 00:45
@thielpa thielpa changed the title chore: add replay integration for sentry chore: Add replay integration for sentry Feb 14, 2025
Copy link

codacy-production bot commented Feb 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e5a20241
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e5a2024) Report Missing Report Missing Report Missing
Head commit (31a5430) 5245 322 6.14%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#369) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@StefanNemeth StefanNemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue here might be data privacy and we might want to add the following config that Sentry recommends (or maybe even setting replaysSessionSampleRate to 0)

replaysSessionSampleRate: 0.1, // This sets the sample rate at 10%. You may want to change it to 100% while in development and then sample at a lower rate in production.
replaysOnErrorSampleRate: 1.0, // If you're not already sampling the entire session, change the sample rate to 100% when sampling sessions where errors occur.

But I'd be good with it.

@StefanNemeth StefanNemeth deployed to test-server-6 February 17, 2025 16:42 — with GitHub Actions Active
@thielpa thielpa force-pushed the sentry-replay-integration branch from 74338bc to a40baca Compare February 17, 2025 19:16
@thielpa thielpa merged commit a22c675 into staging Feb 17, 2025
7 of 9 checks passed
@thielpa thielpa deleted the sentry-replay-integration branch February 17, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants