-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
2006a97
commit 2b6784e
Showing
1 changed file
with
15 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,29 @@ | ||
| ## New submission - Package was archived on CRAN | ||
|
|
||
| This is a resubmission (after package being archived). In this version I have: | ||
| This is a resubmission (after package being archived). | ||
|
|
||
| - Changed 'SystemRequirements' to directly refer to single precision 'fftw3f' and added 'fftw3f_omp'. I also indicated the OpenMP requirement as optional. I removed version requirements (since '3' implies version 3). | ||
| - In this version I have adressed the X-CRAN-Comment and changed 'SystemRequirements' to directly refer to single precision 'fftw3f' and added the optional 'fftw3f_omp' requirement. I also indicated an optional OpenMP requirement. I removed version specifications since they are already implied from the library names. | ||
| - The comment "[The package] does not test for [fftwf]" seems incorrect to me: The file ./configure.ac, line #40, contains a paragraph that tests for single precision functions. The configuration fails with a descriptive error message "The fftw3f library is required." in case it does not find a fitting library. I now added additional information to this error message to make it more clear what is missing. I searched the "Writing R Extensions" documentation for additional mandatory places, where a check should occur, to no avail. | ||
| - I also added other features, unrelated to the comments, since last submission/archiving. | ||
|
|
||
| ## R CMD check results | ||
|
|
||
| 0 errors \| 0 warnings \| 2 notes | ||
|
|
||
| - New submission - Package was archived on CRAN | ||
| - CRAN incoming feasability | ||
|
|
||
| - Note: "Possibly misspelled words in DESCRIPTION: Broek (17:32) Lukas (16:57)." | ||
| - New submission - Package was archived on CRAN | ||
|
|
||
| - Remark: I double-checked the spelling and it is correct. | ||
| - Note: "Possibly misspelled words in DESCRIPTION: Broek (17:32) Lukas (16:57)." | ||
|
|
||
| - X-CRAN-Comment: Archived on 2024-07-01 as issues were not corrected in time. | ||
| - *Remark*: I double-checked the spelling and it is correct. | ||
|
|
||
| - Incorrect 'SystemRequirements' (needs single-precision 'fftw' and does not test for it). | ||
| - X-CRAN-Comment: Archived on 2024-07-01 as issues were not corrected in time. | ||
|
|
||
| - Incorrect 'SystemRequirements' (needs single-precision 'fftw' and does not test for it). | ||
|
|
||
| - checking for future file timestamps | ||
|
|
||
| - unable to verify current time | ||
|
|
||
| - *Remark*: apparently the web service in use is not reachable, the problem seems to be not on my end. |