Skip to content

Commit

Permalink
update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@lschneiderbauer
lschneiderbauer committed Jan 6, 2025
1 parent 12c88ff commit 37d9e34
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cran-comments.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

This is a resubmission (after package being archived).

- In this version I have adressed the X-CRAN-Comment and changed 'SystemRequirements' to directly refer to single precision 'fftw3f' and added the optional 'fftw3f_omp' requirement. I also indicated an optional OpenMP requirement. I removed version specifications since they are already implied from the library names.
- The comment "[The package] does not test for [fftwf]" seems incorrect to me: The file ./configure.ac, line #40, contains a paragraph that tests for single precision functions. The configuration fails with a descriptive error message "The fftw3f library is required." in case it does not find a fitting library. I now added additional information to this error message to make it more clear what is missing. I searched the "Writing R Extensions" documentation for additional mandatory places, where a check should occur, to no avail.
- In this version I have addressed the X-CRAN-Comment and changed 'SystemRequirements' to directly refer to single precision 'fftw3f' and added the optional 'fftw3f_omp' requirement. I also indicated an optional OpenMP requirement. I removed version specifications since they are already implied from the library names.
- The note "[The package] does not test for [fftwf]" seems incorrect to me: The file ./configure.ac, line #40, contains a paragraph that tests for single precision functions. The configuration fails with a descriptive error message "The fftw3f library is required." in case it does not find a fitting library. I now added additional information to this error message to make it more clear what is missing. I searched the "Writing R Extensions" documentation for additional mandatory places, where a check should occur, to no avail.
- I also added other features, unrelated to the comments, since last submission/archiving.

## R CMD check results
Expand All @@ -26,4 +26,4 @@ This is a resubmission (after package being archived).

- unable to verify current time

- *Remark*: apparently the web service in use is not reachable, the problem seems to be not on my end.
- *Remark*: apparently the web service in use is not reachable, the problem seems not to be on my end.

0 comments on commit 37d9e34

Please sign in to comment.