Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Ligatures for the reverted Spanish question/exclamation marks do not work #405

Closed
svitalsky opened this issue Feb 6, 2017 · 3 comments
Closed
Assignees
Labels

Comments

@svitalsky
Copy link

svitalsky commented Feb 6, 2017

After the fix for the issue #397 (typographic (UTF-8) quotes making ligatures with exclamation and question marks) now the standard ligatures "?`" and "!`" do NOT work, so that this MWE:

\documentclass[a4paper, 12pt]{article}
\begin{document}
Hi?`

Hi!`
\end{document}

gives different results with LuaTeX (standard q./ex. marks followed by back quote) and with XeTeX or pdfTeX (reverted Spanish q./ex. marks).

@eg9
Copy link

eg9 commented Feb 6, 2017

The removal of ligatures in luaotfload-features.lua has been too drastic and should be reconsidered.

phi-gamma added a commit to phi-gamma/luaotfload that referenced this issue Feb 6, 2017
@svitalsky
Copy link
Author

I don't “speak Lua” so I may be totally wrong but it seems to me that only lines 1291 to 1294 should be removed and the rest (1305–1317) should be kept.

phi-gamma added a commit to phi-gamma/luaotfload that referenced this issue Feb 7, 2017
V2 of 7250ac9

    commit 7250ac9
    Author: Philipp Gesang <[email protected]>
    Date:   Thu Feb 2 07:38:03 2017 +0100

        [features] remove unneeded tlig features

        Fix lualatex#397

        These four features should not be inserted automatically.

which was reverted in

    commit 9b70f2e
    Author: Philipp Gesang <[email protected]>
    Date:   Mon Feb 6 21:21:48 2017 +0100

        Revert "[features] remove unneeded tlig features"

addressing issues lualatex#397, lualatex#405.
@phi-gamma phi-gamma self-assigned this Feb 11, 2017
@phi-gamma phi-gamma added the bug label Feb 11, 2017
@u-fischer
Copy link

closing as ligatures works as expected now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants