This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Move initialization to the Lua module itself #323
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
luaotfload.sty
loads theluaotfload-main
Lua module and then (inmediatly) runs an initialization function (luaotfload.main()
) offered by this module. This function is, in fact, never run again, and isn't intended to be run more than once, AFAICT.Instead, do initialization directly in the Lua module, straight away.
Motivation behind this change:
One may want to dump a custom format (with LuaTeX). In order to make it feasible and useful, one has to dump all Lua modules in the format. To do this, one could hook into
require
's second searcher so as to save the loader function that it gets in a bytecode register. However, with the current state of affairs, this approach fails to save the initialization step done by callingluaotfload.main()
. This can be solved by moving initialization to the Lua module itself.