Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

add --alias option; catch oddity of Libertine tt #7

Merged
merged 3 commits into from
Apr 25, 2013
Merged

add --alias option; catch oddity of Libertine tt #7

merged 3 commits into from
Apr 25, 2013

Conversation

phi-gamma
Copy link
Member

this addresses the feature request: #4

also, verbosity been adapted so that a log level of 2 emulates the behavior of the original mkluatexfontdb script, whereas fontdbutil defaults to 1 (less clutter)

eroux added a commit that referenced this pull request Apr 25, 2013
add ``--alias`` option; catch oddity of Libertine tt
@eroux eroux merged commit e6b0062 into lualatex:master Apr 25, 2013
@eroux
Copy link
Member

eroux commented Apr 25, 2013

Maybe this could be bugreported to the Libertine authors?

@phi-gamma
Copy link
Member Author

Do you have a sourceforge account? Their tracker doesn’t appear to accept outside submissions: http://sourceforge.net/tracker/?atid=590374&group_id=89513 .
Also, what case do we have? Is there a spec we could cite that prescribes valid subfamily identifiers?

@eroux
Copy link
Member

eroux commented Apr 25, 2013

Looking at the bugs, I found http://sourceforge.net/tracker/?func=detail&aid=3556401&group_id=89513&atid=590374 which might be similar... I'll bugreport though.

@phi-gamma
Copy link
Member Author

Looking at the bugs, I found http://sourceforge.net/tracker/?func=detail&aid=3556401&group_id=89513&atid=590374 which might be similar... I'll bugreport though.

This issue appears to be fixed by changing glyph dimensions. It’s the same font, but we don’t test for something like that.

@eroux
Copy link
Member

eroux commented Apr 25, 2013

Ok, I'll go ahead and report then

@eroux
Copy link
Member

eroux commented Apr 25, 2013

Reported at https://sourceforge.net/tracker/?func=detail&aid=3611833&group_id=89513&atid=590374. There are many weird subfamilies in my otfl-names.lua, example:

{
["familyname"]="EB Garamond 12 All SC",
["filename"]={ "/usr/share/fonts/truetype/pouet/EBGaramond12-AllSC.ttf", false },
["fontname"]="EBGaramond12-AllSC",
["fontstyle_name"]="AllSC",
["fullname"]="EB Garamond 12 Regular All SmallCaps",
["names"]={
["family"]="EB Garamond 12 All SC",
["fullname"]="EB Garamond 12 Regular All SmallCaps",
["psname"]="EBGaramond12-AllSC",
["subfamily"]="AllSC",
},
["size"]={ 120, 1200, 95 },
["slant"]=0,
["weight"]=400,
["width"]=5,
},

...

@phi-gamma
Copy link
Member Author

The issue will occur iff the subfamily string is not covered by the style synonym table, and if the request string equals the family string. With EB Garamond, if we get a

name:EB Garamond 12 All SC

lookup, and with Libertine, if we get

name: Linux Libertine O Mono

-- both could happen more often. The new pull request eliminates an else-branch and fonts with unknown subfamilies should now be matched against their other names as well.

zauguin pushed a commit to zauguin/luaotfload that referenced this pull request Oct 3, 2018
zauguin pushed a commit to zauguin/luaotfload that referenced this pull request Oct 3, 2018
zauguin pushed a commit to zauguin/luaotfload that referenced this pull request Oct 10, 2018
zauguin pushed a commit to zauguin/luaotfload that referenced this pull request Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants