Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added amphora icon #1926

Merged
merged 5 commits into from
Aug 2, 2024
Merged

feat(icons): added amphora icon #1926

merged 5 commits into from
Aug 2, 2024

Conversation

karsa-mistmere
Copy link
Member

closes #1833

What is the purpose of this pull request?

  • New Icon

Description

Adds amphora icon to represent archaeological artefacts.

Icon use case

To represent:

  • museological/archaeological artefacts
  • pottery
  • Greek culture
  • amphora-aging for wines

Alternative icon designs

see #1833

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Feb 25, 2024
Copy link

github-actions bot commented Feb 25, 2024

Added or changed icons

icons/amphora.svg

Preview cohesion icons/message-square-x.svg
icons/amphora.svg
icons/align-horizontal-justify-start.svg
Preview stroke widths icons/amphora.svg
icons/amphora.svg
icons/amphora.svg
DPI Preview (24px) icons/amphora.svg
Icon X-rays icons/amphora.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const AmphoraIcon = createLucideIcon('Amphora', [
  ["path",{"d":"M10 2v5.632c0 .424-.272.795-.653.982A6 6 0 0 0 6 14c.006 4 3 7 5 8"}],
  ["path",{"d":"M10 5H8a2 2 0 0 0 0 4h.68"}],
  ["path",{"d":"M14 2v5.632c0 .424.272.795.652.982A6 6 0 0 1 18 14c0 4-3 7-5 8"}],
  ["path",{"d":"M14 5h2a2 2 0 0 1 0 4h-.68"}],
  ["path",{"d":"M18 22H6"}],
  ["path",{"d":"M9 2h6"}]
])

@jguddas
Copy link
Member

jguddas commented Feb 25, 2024

the handles feel a bit cramped.

@karsa-mistmere
Copy link
Member Author

the handles feel a bit cramped.

How about this?

icons
Open lucide studio

@karsa-mistmere karsa-mistmere changed the title feat(icons): Added amphora icon feat(icons): added amphora icon Mar 1, 2024
Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add some round corners.

Maybe somewhat more in this direction:

icons
Open lucide studio

@karsa-mistmere
Copy link
Member Author

I think we should add some round corners.

Maybe somewhat more in this direction:

iconsOpen lucide studio

Feels a bit like a bong or something. 🤔

@karsa-mistmere
Copy link
Member Author

@jguddas:

icons
Open lucide studio

Is this better?

image

@jguddas
Copy link
Member

jguddas commented May 8, 2024

@jguddas:

iconsOpen lucide studio

Is this better?

image

Still does not spark joy.

What about making it a teardrop shaped?

image

@karsa-mistmere
Copy link
Member Author

Still does not spark joy.

What about making it a teardrop shaped?

We can definitely try that.

icons
Open lucide studio

@karsa-mistmere karsa-mistmere requested a review from jguddas June 6, 2024 09:17
Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the teardrop shaped one.

@karsa-mistmere
Copy link
Member Author

I prefer the teardrop shaped one.

Updated, I think I also prefer it, as it's much less bong-y.

@ericfennis ericfennis merged commit 3c6a8c5 into main Aug 2, 2024
7 checks passed
@ericfennis ericfennis deleted the feat/amphora branch August 2, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archaeological artifacts/museum objects
3 participants