Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): adds microchip icon #1982

Merged
merged 3 commits into from
Aug 2, 2024
Merged

feat(icons): adds microchip icon #1982

merged 3 commits into from
Aug 2, 2024

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • New Icon

Description

We do not currently have an icon that could represent GPUs, this PR adds a microchip icon that could stand in for either GPUs or RAM.

Icon use case

  • gpu
  • ram
  • microchip

Alternative icon designs

image

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • I've based them on the following Lucide icons: cpu

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Mar 14, 2024
Copy link

github-actions bot commented Mar 14, 2024

Added or changed icons

icons/microchip.svg

Preview cohesion icons/message-square-reply.svg
icons/microchip.svg
icons/list-todo.svg
Preview stroke widths icons/microchip.svg
icons/microchip.svg
icons/microchip.svg
DPI Preview (24px) icons/microchip.svg
Icon X-rays icons/microchip.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const MicrochipIcon = createLucideIcon('Microchip', [
  ["path",{"d":"M18 12h2"}],
  ["path",{"d":"M18 16h2"}],
  ["path",{"d":"M18 20h2"}],
  ["path",{"d":"M18 4h2"}],
  ["path",{"d":"M18 8h2"}],
  ["path",{"d":"M4 12h2"}],
  ["path",{"d":"M4 16h2"}],
  ["path",{"d":"M4 20h2"}],
  ["path",{"d":"M4 4h2"}],
  ["path",{"d":"M4 8h2"}],
  ["path",{"d":"M8 2a2 2 0 0 0-2 2v16a2 2 0 0 0 2 2h8a2 2 0 0 0 2-2V4a2 2 0 0 0-2-2h-1.5c-.276 0-.494.227-.562.495a2 2 0 0 1-3.876 0C9.994 2.227 9.776 2 9.5 2z"}]
])

@jguddas
Copy link
Member

jguddas commented Mar 14, 2024

Feels traffic lightly 🚦

@ericfennis
Copy link
Member

Maybe first design is a better fit?

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 18, 2024
@karsa-mistmere
Copy link
Member Author

What do you think about this design?
image

@github-actions github-actions bot removed the Stale label Apr 19, 2024
@ericfennis
Copy link
Member

@karsa-mistmere That will work. I think the right one will look the best on 100% scale with the tiny pins.

@jguddas
Copy link
Member

jguddas commented Apr 19, 2024

All feel hard to identify.

@midnight-wonderer
Copy link

I like the top left one in the alternative designs.
For three reasons:

  • The aspect ratio of the chip looks familiar. While the ratio itself IRL depends on pin count, I work with many ICs with similar ratios to that one.
  • It has eight pins. While six pins are not unusual, eight are easier to come by.
  • No weird line on top of the package. I don't know what that depicts.

PS.
Do you remember this guy?
Old Game

Probably add a curve on top to depict marking similar to the real IC package.

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented May 13, 2024

Some further variations:

image
image

@jguddas
Copy link
Member

jguddas commented May 13, 2024

Do you have the studio link for the right most one 2nd row?

image

@karsa-mistmere
Copy link
Member Author

Do you have the studio link for the right most one 2nd row?

image

I didn't but now I do:

icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented May 13, 2024

image (4)
icons
Open lucide studio

@ericfennis
Copy link
Member

Hmm I'm more in for the first design. To keep it simple.
I know the notch is there in some chips in real life. But feels a bit weird to me to make it part of the design. I think the shape should be consistent with the CPU icon.

But it's my opinion if you all like this design I go with you.

@jguddas
Copy link
Member

jguddas commented Jun 8, 2024

What about rotating it +90°?
Most icons that can be horizontal are horizontal after all?

Copy link

github-actions bot commented Jul 9, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 9, 2024
@ericfennis ericfennis merged commit cf5d6fc into main Aug 2, 2024
7 checks passed
@ericfennis ericfennis deleted the icon/microchip branch August 2, 2024 09:17
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
* feat(icons): adds microchip icon

* feat(icons): fix missing icon

* feat(icons): update microchip with new design

---------

Co-authored-by: Karsa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants