Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add wifi strength icons #2157

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat(icons): add wifi strength icons #2157

merged 1 commit into from
Jul 8, 2024

Conversation

VirtCode
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds a wifi-zero, wifi-low and wifi-high icon, which are all a variant of the wifi icon in lucide with a few bars removed. They are similar to the wifi strength indicators used in almost all operating systems, e.g. Android, iOS, Windows, etc.

Icon use case

These icons can be used to indicate specifically wifi signal strength in an operating systems UI / desktop environment. The signal-* icons often cannot be used for that, as they are usually associated with cellular signal and not wifi.

Alternative icon designs

There are no alternative designs as the icons should be "parts" of the original and complete wifi icon.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: wifi, inspired by the signal-* icons
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

I tried to keep the naming similar to the signal-* icons, so I used the zero, low and high suffixes.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

I just copied the wifi icon and removed the paths that were not needed for the respective icons. Visual center is not relevant in this case.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels May 18, 2024
Copy link

Added or changed icons

icons/wifi-high.svgicons/wifi-low.svgicons/wifi-zero.svg

Preview cohesion icons/square-arrow-out-up-right.svgicons/square-divide.svgicons/square-menu.svg
icons/wifi-high.svgicons/wifi-low.svgicons/wifi-zero.svg
icons/diff.svgicons/youtube.svgicons/file-audio.svg
Preview stroke widths icons/wifi-high.svgicons/wifi-low.svgicons/wifi-zero.svg
icons/wifi-high.svgicons/wifi-low.svgicons/wifi-zero.svg
icons/wifi-high.svgicons/wifi-low.svgicons/wifi-zero.svg
DPI Preview (24px) icons/wifi-high.svg icons/wifi-low.svg icons/wifi-zero.svg
Icon X-rays icons/wifi-high.svg icons/wifi-low.svg icons/wifi-zero.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const WifiHighIcon = createLucideIcon('WifiHigh', [
  ["path",{"d":"M12 20h.01"}],
  ["path",{"d":"M5 12.859a10 10 0 0 1 14 0"}],
  ["path",{"d":"M8.5 16.429a5 5 0 0 1 7 0"}]
])

const WifiLowIcon = createLucideIcon('WifiLow', [
  ["path",{"d":"M12 20h.01"}],
  ["path",{"d":"M8.5 16.429a5 5 0 0 1 7 0"}]
])

const WifiZeroIcon = createLucideIcon('WifiZero', [
  ["path",{"d":"M12 20h.01"}]
])

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@karsa-mistmere karsa-mistmere Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be wifi-medium with wifi geting the wifi-high tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to keep the naming similar to the signal icons, where there is signal and signal-high. But then they also have one variant more (5, not 4).

But I don't mind changing wifi to wifi-high etc. let me know whether I should do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, let's definitely keep wifi as wifi, high should only ever be a tag. But good points, let's first investigate how signal icons are named and tagged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to keep the naming consistent between these two, I would also use the -zero tag for the lowest icon (the dot), as is with signal-zero. As discussed, we also keep wifi as wifi.

So we have three options on how we want to name the two intermediate icons (we have three tags left over to work with from the signal-* icons):

  • wifi-low and wifi-high (as it currently is)
  • wifi-low and wifi-medium
  • wifi-medium and wifi-high

Let me know which option you think is best in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think, should we leave it as is or rename to something like described above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as is! I've just merged it, since @ericfennis has already approved it.

Copy link

github-actions bot commented Jul 8, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 8, 2024
@karsa-mistmere karsa-mistmere merged commit 7cb8677 into lucide-icons:main Jul 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants