-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): add wifi strength icons #2157
Conversation
Added or changed iconsIcons as codeWorks for: const WifiHighIcon = createLucideIcon('WifiHigh', [
["path",{"d":"M12 20h.01"}],
["path",{"d":"M5 12.859a10 10 0 0 1 14 0"}],
["path",{"d":"M8.5 16.429a5 5 0 0 1 7 0"}]
])
const WifiLowIcon = createLucideIcon('WifiLow', [
["path",{"d":"M12 20h.01"}],
["path",{"d":"M8.5 16.429a5 5 0 0 1 7 0"}]
])
const WifiZeroIcon = createLucideIcon('WifiZero', [
["path",{"d":"M12 20h.01"}]
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be wifi-medium
with wifi
geting the wifi-high
tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to keep the naming similar to the signal icons, where there is signal
and signal-high
. But then they also have one variant more (5, not 4).
But I don't mind changing wifi
to wifi-high
etc. let me know whether I should do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, let's definitely keep wifi
as wifi
, high should only ever be a tag. But good points, let's first investigate how signal icons are named and tagged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to keep the naming consistent between these two, I would also use the -zero
tag for the lowest icon (the dot), as is with signal-zero
. As discussed, we also keep wifi
as wifi
.
So we have three options on how we want to name the two intermediate icons (we have three tags left over to work with from the signal-*
icons):
wifi-low
andwifi-high
(as it currently is)wifi-low
andwifi-medium
wifi-medium
andwifi-high
Let me know which option you think is best in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think, should we leave it as is or rename to something like described above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it as is! I've just merged it, since @ericfennis has already approved it.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
What is the purpose of this pull request?
Description
Adds a
wifi-zero
,wifi-low
andwifi-high
icon, which are all a variant of thewifi
icon in lucide with a few bars removed. They are similar to the wifi strength indicators used in almost all operating systems, e.g. Android, iOS, Windows, etc.Icon use case
These icons can be used to indicate specifically wifi signal strength in an operating systems UI / desktop environment. The
signal-*
icons often cannot be used for that, as they are usually associated with cellular signal and not wifi.Alternative icon designs
There are no alternative designs as the icons should be "parts" of the original and complete
wifi
icon.Icon Design Checklist
Concept
Author, credits & license
wifi
, inspired by thesignal-*
iconsNaming
icons/[iconName].json
.I tried to keep the naming similar to the
signal-*
icons, so I used thezero
,low
andhigh
suffixes.Design
I just copied the
wifi
icon and removed the paths that were not needed for the respective icons. Visual center is not relevant in this case.Before Submitting