-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added scan-qr-code
icon
#2247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added or changed iconsIcons as codeWorks for: const ScanQrCodeIcon = createLucideIcon('ScanQrCode', [
["path",{"d":"M17 12v4a1 1 0 0 1-1 1h-4"}],
["path",{"d":"M17 3h2a2 2 0 0 1 2 2v2"}],
["path",{"d":"M17 8V7"}],
["path",{"d":"M21 17v2a2 2 0 0 1-2 2h-2"}],
["path",{"d":"M3 7V5a2 2 0 0 1 2-2h2"}],
["path",{"d":"M7 17h.01"}],
["path",{"d":"M7 21H5a2 2 0 0 1-2-2v-2"}],
["rect",{"x":"7","y":"7","width":"5","height":"5","rx":"1"}]
]) |
jguddas
changed the title
Adding 'scan-qrcode' icon
feat(icons): added Jun 23, 2024
scan-qr-code
icon
jguddas
requested changes
Jun 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon should be renamed to scan-qr-code
.
hiya @jguddas think i've approved everything.. do i need do anything else ? |
@jguddas just nudging this :D |
jguddas
reviewed
Jun 25, 2024
jguddas
approved these changes
Jun 25, 2024
ericfennis
reviewed
Jun 28, 2024
Co-authored-by: Eric Fennis <[email protected]>
ericfennis
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
New scan qr-code icon
Icon use case
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting