Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added scan-qr-code icon #2247

Merged
merged 15 commits into from
Jul 7, 2024
Merged

Conversation

vexkiddy
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

New scan qr-code icon

Icon use case

  1. for indicating a scanner feature of qr-codes
  2. to differentiate from the qr-code icon that doesn't indicate scanning

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 23, 2024
Copy link

github-actions bot commented Jun 23, 2024

Added or changed icons

icons/scan-qr-code.svg

Preview cohesion icons/square-x.svg
icons/scan-qr-code.svg
icons/thumbs-up.svg
Preview stroke widths icons/scan-qr-code.svg
icons/scan-qr-code.svg
icons/scan-qr-code.svg
DPI Preview (24px) icons/scan-qr-code.svg
Icon X-rays icons/scan-qr-code.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ScanQrCodeIcon = createLucideIcon('ScanQrCode', [
  ["path",{"d":"M17 12v4a1 1 0 0 1-1 1h-4"}],
  ["path",{"d":"M17 3h2a2 2 0 0 1 2 2v2"}],
  ["path",{"d":"M17 8V7"}],
  ["path",{"d":"M21 17v2a2 2 0 0 1-2 2h-2"}],
  ["path",{"d":"M3 7V5a2 2 0 0 1 2-2h2"}],
  ["path",{"d":"M7 17h.01"}],
  ["path",{"d":"M7 21H5a2 2 0 0 1-2-2v-2"}],
  ["rect",{"x":"7","y":"7","width":"5","height":"5","rx":"1"}]
])

@vexkiddy vexkiddy mentioned this pull request Jun 23, 2024
5 tasks
@jguddas jguddas changed the title Adding 'scan-qrcode' icon feat(icons): added scan-qr-code icon Jun 23, 2024
Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon should be renamed to scan-qr-code.

icons/scan-qrcode.svg Outdated Show resolved Hide resolved
@vexkiddy
Copy link
Contributor Author

hiya @jguddas think i've approved everything.. do i need do anything else ?

@vexkiddy
Copy link
Contributor Author

@jguddas just nudging this :D

icons/scan-qr-code.json Outdated Show resolved Hide resolved
icons/scan-qr-code.json Outdated Show resolved Hide resolved
@ericfennis ericfennis merged commit 63deb3e into lucide-icons:main Jul 7, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants